Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

analysis/org.eclipse.tracecompass.analysis.profiling.core.tests/src/org/eclipse/tracecompass/analysis/profiling/core/tests/FlameChartDataProviderTest.java (2)

29-30: 💤 Low value

Remove commented-out duplicate imports.

Lines 29 and 59 are commented-out versions of their immediately adjacent active imports — debug artifacts that add noise.

🧹 Proposed cleanup

-//import java.util.stream.Collectors;
 import java.util.stream.Collectors;

 import org.eclipse.tracecompass.tmf.core.model.annotations.Annotation;
-//import org.eclipse.tracecompass.tmf.core.model.annotations.Annotation;

Also applies to: 58-59

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@analysis/org.eclipse.tracecompass.analysis.profiling.core.tests/src/org/eclipse/tracecompass/analysis/profiling/core/tests/FlameChartDataProviderTest.java`
around lines 29 - 30, In FlameChartDataProviderTest remove the commented-out
duplicate import statements for java.util.stream.Collectors (the commented line
above the active import and the duplicate at the later import block) so only the
single active import remains; locate the commented "//import
java.util.stream.Collectors;" entries near the top of the class and delete them
to clean up noise introduced during editing.

---

439-444: 💤 Low value

Dead-code branch in verifyStates after the new assertEquals.

Adding assertEquals(expectedStates.size(), states.size()) at line 439 is the right fix — it catches both under- and over-delivery of states. However, it makes lines 442–444 unreachable: the loop variable i is bounded by states.size(), which is now asserted equal to expectedStates.size(), so i > expectedStates.size() - 1 is always false. The fail(...) can never execute.

🧹 Proposed cleanup

     assertEquals(expectedStates.size(), states.size());
     for (int i = 0; i < states.size(); i++) {
         String entryName = entry.getName();
-        if (i > expectedStates.size() - 1) {
-            fail("Unexpected state at position " + i + FOR_ENTRY + entryName + ": " + states.get(i));
-        }
         ITimeGraphState actual = states.get(i);
         ITimeGraphState expected = expectedStates.get(i);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@analysis/org.eclipse.tracecompass.analysis.profiling.core.tests/src/org/eclipse/tracecompass/analysis/profiling/core/tests/FlameChartDataProviderTest.java`
around lines 439 - 444, The new assertEquals(expectedStates.size(),
states.size()) makes the conditional inside verifyStates' loop unreachable;
remove the dead branch that checks "if (i > expectedStates.size() - 1) {
fail(... entry.getName() ... states.get(i)) }" or replace the loop to iterate
over expectedStates.size() and directly compare elements, so the fail(...) call
and the unreachable i check are deleted; update verifyStates to perform direct
comparisons between expectedStates.get(i) and states.get(i) (using
entry.getName() only in failure messages).